Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "BigQuery: Get query results as pandas DataFrame" #4527

Closed
wants to merge 3 commits into from
Closed

Revert "BigQuery: Get query results as pandas DataFrame" #4527

wants to merge 3 commits into from

Conversation

alixhami
Copy link
Contributor

@alixhami alixhami commented Dec 4, 2017

Reverts #4354 due to failing python 2.7 tests

@alixhami alixhami requested a review from dhermes December 4, 2017 23:45
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 4, 2017
@tswast
Copy link
Contributor

tswast commented Dec 4, 2017

@dhermes do you want to merge pre-CI to fix failing tests?

@dhermes
Copy link
Contributor

dhermes commented Dec 4, 2017

@tswast I don't think we need to revert? The issue seems minor.

@alixhami
Copy link
Contributor Author

alixhami commented Dec 5, 2017

Found a fix and sent a PR #4528

@alixhami alixhami closed this Dec 5, 2017
@dhermes dhermes deleted the revert-4354-pandas-integration branch December 5, 2017 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhermes dhermes Awaiting requested review from dhermes

@lukesneeringer lukesneeringer Awaiting requested review from lukesneeringer

@tseaver tseaver Awaiting requested review from tseaver

@tswast tswast Awaiting requested review from tswast

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alixhami @tswast @dhermes @googlebot